jan.bertram/piano_repertoire
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fixes bug: crash by marking work as mastered twice, updates README with more known bugs

Browse Source
This commit is contained in:
Jan Bertram
2023-11-16 11:15:10 +01:00
parent c6057ff8f7
commit fb13941756
2 changed files with 18 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
README.md
View File

@@ -27,7 +27,7 @@ At the moment, an alpha version is undertaken, with these features:
- Works are shown sorted by composer and opus/work_directory-number (`s`, `smo`) or by composer and collection (`sm`) - Works are shown sorted by composer and opus/work_directory-number (`s`, `smo`) or by composer and collection (`sm`)
- Remove work or movement from being mastered for active user (`r number_of_work` or `r number_of_work number_of_movement`) - Remove work or movement from being mastered for active user (`r number_of_work` or `r number_of_work number_of_movement`)
- Remove user (`delete_my_user_record_including_all_mastered_works`) - Remove user (`delete_my_user_record_including_all_mastered_works`)
- (planned) Fix known bugs - Fix bug: double marking crashes the program
_(planned) Release piano_repertoire_cli V 0.0.1 alpha (learn about versioning before)_ _(planned) Release piano_repertoire_cli V 0.0.1 alpha (learn about versioning before)_
@@ -44,4 +44,6 @@ _(planned) Port funtionality to a kivy-GUI_
## Known Bugs ## Known Bugs
- Marking a piece as mastered the second time, the database won’t insert the entry and the program will crash - User numbers are allowed to set without a user being present, with marking works as mastered leading to crash the program
- Trying to mark works as mastered that are not present crashes the program
- Providing alphabetic chars where numbers are expected crashes the program

22
rep_cli.py
View File

@@ -218,20 +218,26 @@ class Session:
work = work_under_id(work_id, self.db_agent) work = work_under_id(work_id, self.db_agent)
if len(arguments) > 1: # in case there is a movement number given if len(arguments) > 1: # in case there is a movement number given
mov_number = int(arguments[1]) mov_number = int(arguments[1])
sql_command = f''' if self.movement_is_mastered(work_id, mov_number):
INSERT INTO is_able_to_play (work_id, mov_id, pianist_id) resultstring += f'Already marked as mastered: {work.pretty_mov(mov_number)}\n'
VALUES ({work_id}, {mov_number}, {self.user}) else:
'''
self.db_agent.execute(sql_command)
resultstring += f'{work.pretty_mov(mov_number)}\n'
else: # mark all movements of the work as mastered
for mov_number in work.values['movements'].keys():
sql_command = f''' sql_command = f'''
INSERT INTO is_able_to_play (work_id, mov_id, pianist_id) INSERT INTO is_able_to_play (work_id, mov_id, pianist_id)
VALUES ({work_id}, {mov_number}, {self.user}) VALUES ({work_id}, {mov_number}, {self.user})
''' '''
self.db_agent.execute(sql_command) self.db_agent.execute(sql_command)
resultstring += f'{work.pretty_mov(mov_number)}\n' resultstring += f'{work.pretty_mov(mov_number)}\n'
else: # mark all movements of the work as mastered
for mov_number in work.values['movements'].keys():
if self.movement_is_mastered(work_id, mov_number):
resultstring += f'Already marked as mastered: {work.pretty_mov(mov_number)}\n'
else:
sql_command = f'''
INSERT INTO is_able_to_play (work_id, mov_id, pianist_id)
VALUES ({work_id}, {mov_number}, {self.user})
'''
self.db_agent.execute(sql_command)
resultstring += f'{work.pretty_mov(mov_number)}\n'
return resultstring return resultstring
def remove_work_as_mastered(self, arguments): def remove_work_as_mastered(self, arguments):